Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #288
Fixes an issue where the
base
path is not included in the/public/hot
file. This issue only impacts thenpm run dev
command. When building, assets are appended with the configured base.base
descriptionWhat
If we were to set the
base
path to/frontend/
:Then the dev server will be appended with
/frontend/
:However, the hot file we write will not contain the
/frontend
base path:So we do not create the correct URLs in Laravel. With this change in place, the hot file now contains the correct base.
Implementation notes
Vite normalizes the
base
value before we get access to it. The following table shows how Vite normalizes different values and what we end up appending to the hot file.The only valid values for this option are
undefined
, an empty string,./
, or an absolute URL, i.e.,https://example.com/...
or/...
undefined
"/"
""
""
"/"
""
"/"
"/"
""
"./"
"/"
""
"/frontend"
"/frontend/"
"/frontend"
"/frontend/"
"/frontend/"
"/frontend"
"https://example.com"
"/"
""
"https://example.com/"
"/"
""
"https://example.com/frontend"
"/frontend/"
"/frontend"
"https://example.com/frontend/"
"/frontend/"
"/frontend"