Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bedrockvaletdriver #1289

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

EHLOVader
Copy link
Contributor

I'd experienced an issue with the bedrock valet driver for awhile specific to the custom wp-admin route provided by plugins, like the hidden backend feature in iThemes security.

I finally dug into it and found that the driver is out of sync with the WordPress driver and had a few headers missing from the other drivers. So I tested updating it to match the WordPress driver and it fixed my problem.

This uses the built in routing available instead of assuming that the folder has an index.php or is part of WordPress core.

If accepted please kindly add [hacktoberfest-accepted] label too, thanks.

@EHLOVader EHLOVader changed the title sFix bedrockvaletdriver Fix bedrockvaletdriver Oct 23, 2022
@EHLOVader
Copy link
Contributor Author

EHLOVader commented Oct 23, 2022

I'm not seeing the same output from the failed check. Why does it see spaces where there were none?

Ok I think it fixed itself locally but hadn't been pushed. I think I found it.

@mattstauffer mattstauffer merged commit 3f91526 into laravel:master Nov 10, 2022
@mattstauffer
Copy link
Collaborator

Thanks @EHLOVader!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants