[2.x] Add namespace check to Auth routes #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing the Route default namespace (as is default in Laravel 8), the Auth routes will break. This is the case for new Laravel 8 apps, but also when you want to upgrade to match the new defaults.
I understand this package is now deprecated, but if this is the only change it might be worth considering to give users the time to upgrade/change/get comfortable to Jetstream and let it stabilize/grow a bit first.
This checks if the Class with namespace exists. If it doesn't, it adds the default namespace, to compensate for laravel/laravel@58a98ef#diff-b467cc786635bd6945b17726282f1c64
Fixes #138 #141 #142