[4.x] use Authorization header instead of using the access_token query parameter
#430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
access_token query parameteraccess_token query parameter
driesvints
approved these changes
Feb 4, 2020
|
Thanks all for the prompt action/merge/release 👍 |
fmendozaro
added a commit
to fmendozaro/socialite
that referenced
this pull request
Feb 12, 2020
…ry parameter Github is deprecating using access_token as query parameter and they recommend sending OAuth tokens using the Authorization header. Based on this PR: laravel#430
fideloper
added a commit
to fideloper/socialite
that referenced
this pull request
Feb 20, 2020
taylorotwell
added a commit
that referenced
this pull request
Feb 20, 2020
[3.x] Backport #430 - use authorization header for GitHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github is deprecating using access_token as query parameter and they recommend sending OAuth tokens using the Authorization header.
as mentioned in this issue #427
see https://developer.github.com/v3/#oauth2-token-sent-in-a-header