[5.x] Only use the read_user scope for GitLab by default
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
gitlab-use-restricted-scope
branch
from
bf3e061 to
60e5809
Compare
- If the user created the application without checking any of the scope checkboxes, GitLab will implicitly check all the boxes when submitting the form. This can result in all scopes being granted to the application, which is very broad. - If the user created the application with only the `read_user` scope being grantable to applications, Socialite will work correctly out of the box (without requiring the user to override the scopes being requested on the Laravel side). This closes laravel#402.
Calinou
force-pushed
the
gitlab-use-restricted-scope
branch
from
60e5809 to
b5b4bff
Compare
Calinou
changed the title
read_user for GitLab by defaultread_user scope for GitLab by default
driesvints
approved these changes
Oct 28, 2019
driesvints
changed the title
read_user scope for GitLab by defaultread_user scope for GitLab by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the GitLab provider use a smaller scope by default. This has two benefits:
read_userscope being grantable to applications, Socialite will work correctly out of the box (without requiring the user to override the scopes being requested on the Laravel side).This closes #402.