Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting Swoole server mode #739

Closed
wants to merge 4 commits into from
Closed

Conversation

smortexa
Copy link
Contributor

@smortexa smortexa commented Aug 27, 2023

Follows #666

Currently, running the php artisan octane:start --server=swoole --host=0.0.0.0 --port=80 --mode=1 will throw the following error:

"exception": "[object] (Symfony\\Component\\Console\\Exception\\RuntimeException(code: 0): The \"--mode\" option does not exist. at /var/www/html/vendor/symfony/console/Input/ArgvInput.php:223)
[stacktrace]
#0 /var/www/html/vendor/symfony/console/Input/ArgvInput.php(150): Symfony\\Component\\Console\\Input\\ArgvInput->addLongOption('mode', '1')
#1 /var/www/html/vendor/symfony/console/Input/ArgvInput.php(85): Symfony\\Component\\Console\\Input\\ArgvInput->parseLongOption('--mode=1')
#2 /var/www/html/vendor/symfony/console/Input/ArgvInput.php(74): Symfony\\Component\\Console\\Input\\ArgvInput->parseToken('--mode=1', true)
#3 /var/www/html/vendor/symfony/console/Input/Input.php(55): Symfony\\Component\\Console\\Input\\ArgvInput->parse()
#4 /var/www/html/vendor/symfony/console/Command/Command.php(285): Symfony\\Component\\Console\\Input\\Input->bind(Object(Symfony\\Component\\Console\\Input\\InputDefinition))
#5 /var/www/html/vendor/laravel/framework/src/Illuminate/Console/Command.php(180): Symfony\\Component\\Console\\Command\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Illuminate\\Console\\OutputStyle))
#6 /var/www/html/vendor/symfony/console/Application.php(1081): Illuminate\\Console\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#7 /var/www/html/vendor/symfony/console/Application.php(320): Symfony\\Component\\Console\\Application->doRunCommand(Object(Laravel\\Octane\\Commands\\StartCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#8 /var/www/html/vendor/symfony/console/Application.php(174): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#9 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php(201): Symfony\\Component\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#10 /var/www/html/artisan(35): Illuminate\\Foundation\\Console\\Kernel->handle(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#11 {main}

@smortexa smortexa marked this pull request as draft August 27, 2023 19:05
@smortexa smortexa marked this pull request as ready for review August 27, 2023 19:16
@smortexa smortexa changed the title Fix the The "--mode" option does not exist. while setting Swoole server mode Fix setting Swoole server mode Aug 27, 2023
@taylorotwell
Copy link
Member

How would this actually get the mode to the octane:swoole command? The option isn't present in octane:start?

@smortexa
Copy link
Contributor Author

@taylorotwell The mode option added to octane:start

@smortexa smortexa deleted the fix-swoole-mode branch August 28, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants