Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] apply our new Pint rule to the /tests directory #54325

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

browner12
Copy link
Contributor

I originally omitted these files to keep the PR smaller, but adding back now for consistent styling throughout repo. these are purely indentation whitespace changes.

the bad-syntax-strategy.php file is not valid PHP so we need to omit it, or it throws a Pint error.

I originally omitted these files to keep the PR smaller, but adding back now for consistent styling throughout repo. these are purely indentation whitespace changes.

the `bad-syntax-strategy.php` file is not valid PHP so we need to omit it, or it throws a Pint error.
@browner12
Copy link
Contributor Author

since this is a large PR that mostly contains whitespace changes, you can toggle the hiding the whitespace in the diff viewer to confirm only the behavior changes.

@AndrewMast
Copy link

I really like this push to include the styling rules into the repo, especially since it means we can use it ourselves when making pull requests or on our own projects. Maybe once we migrate these rules, we can add them to the base project laravel/laravel.

I didn't realize we could toggle whitespace in the diff viewer, thanks for that haha.

@taylorotwell taylorotwell merged commit 79b44b1 into laravel:11.x Jan 23, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants