Add self to HasCollection type param in Model #54311
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Psalm is giving me this error when trying to extend the Model class.
Extended template param TModel of Illuminate\Database\Eloquent\Collection<array-key, static> expects type Illuminate\Database\Eloquent\Model, type static given (see https://psalm.dev/183)
The proposed change solves the error by indicating that whatever type resolved by
static
should also resolve asself
AKA Model, according to the Collection template requirement.My composer.json has: