Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☁️ #53623

Merged
merged 8 commits into from
Nov 22, 2024
Merged

☁️ #53623

merged 8 commits into from
Nov 22, 2024

Conversation

taylorotwell
Copy link
Member

No description provided.

@taylorotwell taylorotwell marked this pull request as draft November 21, 2024 17:26
@taylorotwell taylorotwell marked this pull request as ready for review November 22, 2024 14:00
@taylorotwell taylorotwell merged commit abc1faa into 11.x Nov 22, 2024
35 checks passed
@taylorotwell taylorotwell deleted the cloud branch November 22, 2024 14:00
@olympikesoft
Copy link

what is this?

@jhm-ciberman
Copy link

@binaryfire
Copy link

Not sure how I feel about SaaS-related code being added to the framework to be honest. Shouldn't this be in a package?

@jhm-ciberman
Copy link

@binaryfire Taylor created Laravel for free, so adding just 22 lines in a huge framework that contains thousands and thousands of lines of code it's not a big deal.

After all, Laravel already contains hundred of lines of code for compatibility with other SaaS products (AWS, Mailgun, Algolia, etc) and no one is complaining.

@binaryfire
Copy link

@jhm-ciberman I’m not making light of Taylor’s contributions at all.

The concern is opening the door to going down the same road that Vercel has with Next. Next users are heavily locked into their ecosystem now. A bunch of features only work properly on their platform. And it happened gradually over time.

I think it’s a reasonable concern.

@olympikesoft
Copy link

I think the same, could be the creator but if close the project i think people will go away like vercel has done with next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants