[11.x] use `exists()` instead of `count()` #53328

browner12 · 2024-10-28T19:55:11Z

we only need to check for existence of a record here, not for the actual count, and exists() is generally more performant than a count.

we only need to check for existence of a record here, not for the actual count, and `exists()` is generally more performant than a count.

- add an "exists" assertions, and update `mockCountBuilder()` to accept this first, and adjust all the calls to it. - I thought about renaming `mockCountBuilder()` to `mockBuilder()`, which would probably be a little clearer now, but I wanted to keep this easy to review. if this is accepted, I'd probably go back and make that semantic change separately.

browner12 added 2 commits October 28, 2024 14:54

use exists() instead of count()

d1d80c3

we only need to check for existence of a record here, not for the actual count, and `exists()` is generally more performant than a count.

taylorotwell merged commit 36b6991 into laravel:11.x Oct 29, 2024
31 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.x] use `exists()` instead of `count()` #53328

[11.x] use `exists()` instead of `count()` #53328

browner12 commented Oct 28, 2024

[11.x] use exists() instead of count() #53328

[11.x] use exists() instead of count() #53328

Conversation

browner12 commented Oct 28, 2024

[11.x] use `exists()` instead of `count()` #53328

[11.x] use `exists()` instead of `count()` #53328