[11.x] Move Defer classes to Support component and add Illuminate\Support\defer function
#52801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid using global `defer()` function when it can be defined in environment such as Swoole Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
crynobone
commented
Sep 16, 2024
| @@ -3,7 +3,7 @@ | |||
| namespace Illuminate\Contracts\Concurrency; | |||
|
|
|||
| use Closure; | |||
| use Illuminate\Foundation\Defer\DeferredCallback; | |||
| use Illuminate\Concurrency\Defer\DeferredCallback; | |||
There was a problem hiding this comment.
@taylorotwell This might be a breaking change but as Concurrency is still in beta we might allow it.
|
Doesn't the For example, |
|
@crynobone personally I would maybe put this in Support instead of Concurrency. |
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
@taylorotwell moved to Support |
crynobone
changed the title
Illuminate\Support\defer function
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also avoid using global
defer()function when it can be defined in environment such as Swoole