[11.x] Dump Postgres migration table from all schemas

[simon-tma]

If a pgsql connection is using a search_path other than public, the current schema:dump command fails because public.migrations doesn't exist. pg_dump doesn't provide a way to set search_path, so just dump the migrations table from all schemas instead.

[hafezdivandari]

Changing 'database.migrations.table' => 'migrations' config value to 'your_schema.migrations' helps?

framework/config/database.php

Line 126 in 68e88bb

'table' => 'migrations',

[simon-tma]

Only if there's only a single connection used

[hafezdivandari]

pg_dump doesn't provide a way to set search_path

But pg_dump has -n option to declare schema, what am I missing here?

[simon-tma]

-n is a filter. It does not set search_path, so the passed table name still only looks in search_path.

[taylorotwell]

I'm very very scared to change this on a patch release. It almost always breaks existing apps.

[hafezdivandari]

I'm sorry but the changes here aren't valid. The hasMigrationTable() respects the search_path but then you want to dump migrations table on every schema. This definitely causes problem!

[simon-tma]

I'm sorry but the changes here aren't valid. The hasMigrationTable() respects the search_path but then you want to dump migrations table on every schema. This definitely causes problem!

All tables across all schemas are already dumped, this change just now dumps the data from all migrations tables as well rather than just public.migrations. Please explain how that definitely causes problems.

[hafezdivandari]

1. One may have declared migrations table with schema name included like 'my_schema.migrations', you are prefixing this with an additional *, so it becomes '*.my_schema.migrations', which is breaking?
2. We expect only schemas declared on search_path to be dumped right? but you are saying: All tables across all schemas are already dumped, this change just now dumps the data from all migrations tables as well
3. hasMigrationTable() determines if the public.migrations exists, then you want to dump every migrations table on every schemas?

[simon-tma]

1. Corrected
2. No, all tables are dumped regardless of schema or search_path.
3. hasMigrationTable() determines if migrations exists within the search_path, then dumps the data from public.migrations which fails if the migrations table is in a different schema. I'm still not sure how changing this to dump the data from migrations tables across all schema will definitely break things

[simon-tma]

Updated the patch. It now attempts to detect if a single schema is in use and then dumps only that table. If the migration table already has a schema attached it is left as-is.

[hafezdivandari]

@simon-tma Would you please check PR #52098 to see if it resolves your issue?

[simon-tma]

It does not

[hafezdivandari]

@simon-tma would you please share more info? what was the output? What is your search_path and where is your migrations table?

command fails because public.migrations doesn't exist

This shouldn't happen anymore using that PR, because we are checking if the table exists before dumping.

[driesvints]

Going to close this one now for a lack of activity.