[11.x] Fix the edge case of .php extension chopping in make commands

[osbre]

As pointed by @jasonmccreary in this comment: #51843 (comment)

Update: dependent on #51924

[timacdonald]

This is not the same functionality as the origin is also problematic.

rtrim will trim characters, not the given string as a whole.

php artisan make:model Foo.php

// Foo

php artisan make:model Sponsorship

// Sponsorshi

php artisan make:model Photograph

// Photogra

[osbre]

Good catch. Seems like a good case for introducing Str::chop 😅 will send a PR shortly

[timacdonald]

@osbre, I have just created a PR to fix the make command and introduce a helper function for this type of string manipulation.

[timacdonald]

#51910

[osbre]

@timacdonald Good job! That was fast lol. I was just deciding between chop and chopEnd and you've already done it 😂