[9.x] Database queries containing JSON paths support array index braces, part 2 #41767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #38391 meant to fix #26415
Related to today's PR #41756
The previous PR allowed the above query to match by JSON array index. But the fixes didn't apply to the Postgres database driver that overrides
PostgresGrammer@wrapJsonSelector()
.Postgres does already support this:
This fix allows the first PHP snippet to also work, bringing it in line with the other database drivers. SQL:
Now the GitHub Actions config has a Postgres container I've added some integration tests.
Illuminate\Database\Schema\Grammars\Grammar@wrapJsonFieldAndPath()
was a copy and paste duplicate fromIlluminate\Database\Query\Grammars\Grammar
and didn't receive the same fixes from the previous PR. It's a far edge case for column methodsvirtualAsJson()
andstoredAsJson()
to use an array index but it probably makes sense for these classes to share a trait for compiling SQL containing JSON paths.