Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Note that the GD extension is required for generating images #29770

Merged
merged 2 commits into from
Aug 28, 2019
Merged

[5.8] Note that the GD extension is required for generating images #29770

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
873b860
Note that the GD extension is required for generating images
GrahamCampbell Aug 27, 2019
ad9fb05
Fixed skips
GrahamCampbell Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed skips
  • Loading branch information
@GrahamCampbell
GrahamCampbell committed Aug 27, 2019
commit ad9fb0561ae85efd7b6b445f414c793ea245addb
6 changes: 3 additions & 3 deletions tests/Http/HttpTestingFileFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ class HttpTestingFileFactoryTest extends TestCase
{
public function testImagePng()
{
if (! function_exists('imagejpeg')) {
$this->markTestSkipped('The extension gd is missing from your system.');
if (! function_exists('imagepng')) {
$this->markTestSkipped('The extension gd is missing from your system or was compiled without PNG support.');
}

$image = (new FileFactory)->image('test.png', 15, 20);
Expand All @@ -25,7 +25,7 @@ public function testImagePng()
public function testImageJpeg()
{
if (! function_exists('imagejpeg')) {
$this->markTestSkipped('The extension gd is missing from your system.');
$this->markTestSkipped('The extension gd is missing from your system or was compiled without JPEG support.');
}

$image = (new FileFactory)->image('test.jpeg', 15, 20);
Expand Down