New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Fix whereDay() and whereMonth() with raw expressions #29134

Merged

taylorotwell merged 1 commit into laravel:5.8 from staudenmeir:where

Jul 11, 2019

Contributor

staudenmeir commented Jul 10, 2019

#28185 broke whereDay() and whereMonth() with raw expressions:

DB::table('users')->whereDay('created_at', DB::raw('"day_column"'))->get();

// expected
select * from "users" where strftime('%d', "created_at") = cast("day_column" as text)

// actual
select * from "users" where strftime('%d', "created_at") = cast(? as text)


          Fix whereDay() and whereMonth() with raw expressions

15917aa

taylorotwell merged commit bb5ba2d into laravel:5.8

staudenmeir deleted the where branch

July 11, 2019 02:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet