[5.8] Improve event list command #28177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayBizzle
reviewed
Apr 11, 2019
| return $this->error('Your application doesn\'t have any events matching the given criteria.'); | ||
| } | ||
|
|
||
| return $this->error('Your application doesn\'t has any events, listeners.'); |
There was a problem hiding this comment.
Typo....should be...
return $this->error('Your application doesn\'t have any event listeners.');There was a problem hiding this comment.
Thank you for your comment! This command still lists an event to the table even it doesn't has any listeners. The error message is only printed when no event is found, so I think the right message may be:
'Your application doesn\'t have any events.'But Mr.Otwell always modifies the message of an accepted commit if he needs. Therefore, let him decide finally.
There was a problem hiding this comment.
'Your application doesn't have any events.'
- If you define the word "event" as a synonym for "event class" -> might be true then.
- If you define the word "event" as the name of an event ( = strings that do not have to match the name of an event class) that can be passed to the
event()helper function - for exampleevent('event-'.time())- then the statement is not valid, because it is not possible to automatically detect (all) event names. Therefore the command cannot decide if the application does not have any events.
There was a problem hiding this comment.
But Mr.Otwell always modifies the message of an accepted commit if he needs. Therefore, let him decide finally.
Indeed, such changes have been made:
cde1c5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two things I think the "event:list" command can be improved.