[5.6] Fixed league/flysystem-cached-adapter dependency #23817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another reason to revert would be that it's an possible breaking change to add more dependencies to a released version. What if someone has code that conflicts with this package? |
|
Probably the most balanced solution would be to leave it on |
|
Yeh, I agree actually. Will update this PR. :) |
GrahamCampbell
changed the title
nunomaduro
approved these changes
Apr 6, 2018
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 7, 2018
* Revert "Add missing dependency on league/flysystem-cached-adapter (laravel#23815)" This reverts commit d60b1c1. * Added to suggested deps * Removed duplicate * Sync with main composer.json * Added to require-dev
TBlindaruk
pushed a commit
to TBlindaruk/laravel-framework
that referenced
this pull request
Apr 7, 2018
* Revert "Add missing dependency on league/flysystem-cached-adapter (laravel#23815)" This reverts commit d60b1c1. * Added to suggested deps * Removed duplicate * Sync with main composer.json * Added to require-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is already listed as a suggested dependency. We need not install everything.
Reverts #23815.