Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] Use path helpers for Console commands #22971

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

Pascal-So
Copy link
Contributor

@Pascal-So Pascal-So commented Jan 31, 2018

When trying to use a custom public path, the Op of issue #18550 was advised to override the path.public binding. I did the same for my application, however I was then unable to use the artisan serve command, because that just uses the hardcoded value in publicPath(), instead of the bindings.

The error message I received was this:

$ php artisan serve
In ServeCommand.php line 35:

  chdir(): No such file or directory (errno 2)

StorageLinkCommand.php already uses the public_path() helper (although with the argument 'storage'), so it seems this commit doesn't introduce a new dependency on these helpers that wasn't there before.

If there was a specific reason to not use these helper functions, maybe we can find some other solution.

@Pascal-So Pascal-So changed the title Use path helpers for Console commands [5.5] Use path helpers for Console commands Jan 31, 2018
@taylorotwell taylorotwell merged commit d14395f into laravel:5.5 Jan 31, 2018
@Pascal-So Pascal-So deleted the use-path-helpers branch January 31, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants