[5.5] Use path helpers for Console commands #22971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use a custom public path, the Op of issue #18550 was advised to override the
path.public
binding. I did the same for my application, however I was then unable to use theartisan serve
command, because that just uses the hardcoded value inpublicPath()
, instead of the bindings.The error message I received was this:
StorageLinkCommand.php already uses the
public_path()
helper (although with the argument'storage'
), so it seems this commit doesn't introduce a new dependency on these helpers that wasn't there before.If there was a specific reason to not use these helper functions, maybe we can find some other solution.