[5.5] Supporting Laravel-Mix PR #1246, HMR w/ different Hosts and Ports #22826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the 'mix' helper function to take URLs coming from the hot file. This feature is fully backwards compatible. Supporting Laravel-Mix Pull Request #1246, allowing Hot Module Reloading with custom hosts and ports Do not merge straight away, awaiting reply of laravel-mix/laravel-mix#1246 Let me know if you require tests
|
Will let @JeffreyWay chime in on this. |
|
Can you explain with this does in kinda simple terms? Sorry, I'm not super up to speed on the latest front-end stuff. 😄 |
ntzm
reviewed
Jan 17, 2018
| @@ -555,6 +555,12 @@ function mix($path, $manifestDirectory = '') | |||
| } | |||
|
|
|||
| if (file_exists(public_path($manifestDirectory.'/hot'))) { | |||
| $url = file_get_contents(public_path($manifestDirectory.'/hot')); | |||
|
|
|||
| if (Str::startsWith($url, 'http://') || Str::startsWith($url, 'https://')) { | |||
There was a problem hiding this comment.
This line can be shortened to:
if (Str::startsWith($url, ['http://', 'https://'])) {
|
Yep, this is fully backward compatible and fine to merge. |
pelletiermaxime
referenced
this pull request
in laravel-mix/laravel-mix
Mar 3, 2018
Once Laravel is updated to reflect the change, we can add this back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part One: #21545
This PR changes the 'mix' helper function to take URLs coming from the
hotfile. This feature should be fully backwards compatible with older Laravel Mix & Laravel installs.Supporting Laravel-Mix Pull Request laravel-mix/laravel-mix#1246, allowing Hot Module Reloading with custom hosts and ports, allowing hot-module reloading across networks.
Please don't merge straight away, I'm awaiting a reply to laravel-mix/laravel-mix#1246JefferyWay merged laravel-mix/laravel-mix#1246. Should be good to go
Let me know if you require tests for this code change,
Edit: Just realised that there's no other use of
Str::in the class. Let me know if you want me to use the native php string functions.