[5.5] Fix SQS Queue for PHP7.2

[laurencei]

Simple fix for issue #22373

Includes a test to prevent regression (this test fails on 7.2 without the fix).

I checked the Git history for this file. We can safely backport this fix all the way back to Laravel 5.1 if you want to backport PHP7.2 support to previous Laravel versions. Let me know, and I'll do PRs for the other versions for you.

[sisve]

Includes a test to prevent regression (this test fails on 7.2 without the fix).

Woho! ;)

[schystz]

+1 would love to get the fix for Laravel 5.4 as well :)

[GrahamCampbell]

Only Laravel 5.5 LTS is supported.

[Szasza]

@GrahamCampbell would it be possible to do a release of illuminate/queue as well so Lumen would be patched too?

Thank you in advance for the consideration.

[Szasza]

Thank you 🎆

[acaballes]

Hi, problem still occurs from laravel 5.5.19 to 5.5.28. "count(): Parameter must be an array or an object that implements Countable" error still occurs.

code li causes the error:
$images = count($this->input('images')) - 1;

[sisve]

@acaballes it would be helpful if you could provide a stack trace or tell us which framework file has the issue, and how to reproduce it.

[acaballes]

@sisve I have a form that submits post request for multiple files upload that looks like this for example:

  <input type="file" class="form-control" id="images" name="images[]" onchange="preview_images();" multiple>

...... and submitting the form and handles the post request in /var/www/app/Http/Requests/PostRequest.php:

use Illuminate\Foundation\Http\FormRequest;
class PostRequest extends FormRequest
{
.
.
.
public function rules()
{
     // Text or images validation
     $rules = [
            'text' => 'required_without_all:images.0'
      ];
     $images = count($this->input('images')) - 1; /****** THIS LINE FALSE THE ERROR I REPORTED ***/
     foreach (range(0, $images) as $index) {
           $rules['images.' . $index] = 'image|mimes:jpeg,jpg,gif,png|max:2048';`
     }
     return $rules;
}

.....additional information in Illuminate\Foundation\Http\Kernel handle:

$kernel = $app->make(Illuminate\Contracts\Http\Kernel::class);
$response = $kernel->handle(
    $request = Illuminate\Http\Request::capture() // THIS LINE HAVE 1 ARGUMENT returns Request {#56 ▶}
);
$response->send();
$kernel->terminate($request, $response);

now, I think the request is not capturing and sending the multiple files upload in the form?
Additionally, the post data is not working using Illuminate\Foundation\Http\FormRequest by $this->input('images'), but it works fine using Illuminate\Http\Request by $request->images.

Thanks,
Algie