[5.5] Prevent authentication if 'password' is the only field specified to the auth 'attempt' method #22167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out that calling this :
will result to
true
if the first row returned from the database is also the one using this password, without the need to specify an identifier (email
for example).This happens because the
foreach
loop inside theretrieveByCredentials
function will never call$query->where($key, $value)
and then will systematicaly call$query->first()
without any SQL condition applied.You can easily reproduct this by trying to authenticate the user represented by the first row of your
users
table without specifying his email or username.I don't think this is an expected behaviour.
This issue exists for 5.5 and 5.4 (I did not check older versions but I guess it's also present).