Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Refactor Arr::flatten to prevent a serious performance hit #22103

Merged
merged 2 commits into from
Nov 16, 2017
Merged

[5.5] Refactor Arr::flatten to prevent a serious performance hit #22103

merged 2 commits into from
Nov 16, 2017

Conversation

leonrenkema
Copy link

Change that resolves #22086

The root cause of the problem is calling array_merge for every item in the array, that has a serious performance hit on large arrays.

@taylorotwell taylorotwell merged commit f479d9a into laravel:5.5 Nov 16, 2017
@GrahamCampbell GrahamCampbell changed the title Refactor Arr::flatten to prevent a serious performance hit. [5.5] Refactor Arr::flatten to prevent a serious performance hit. Nov 18, 2017
@GrahamCampbell GrahamCampbell changed the title [5.5] Refactor Arr::flatten to prevent a serious performance hit. [5.5] Refactor Arr::flatten to prevent a serious performance hit Nov 18, 2017
@leonrenkema leonrenkema deleted the arr_flatten_performance branch August 25, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonrenkema @taylorotwell