[5.5] Make Collection::dd() & Collection::dump() show the same result

[antonioribeiro]

If you do

collect([1, 3])->dump(5);

echo "------------------------------------------\n";

collect([1, 3])->dd(5);

You'll see dd() and dump() shows a completely different result:

5
Illuminate\Support\Collection {#783
  #items: array:2 [
    0 => 1
    1 => 3
  ]
}
------------------------------------------
array:2 [
  0 => 1
  1 => 3
]

This PR fix this so they both behave the same way:

5
Illuminate\Support\Collection {#783
  #items: array:2 [
    0 => 1
    1 => 3
  ]
}
------------------------------------------
5
Illuminate\Support\Collection {#783
  #items: array:2 [
    0 => 1
    1 => 3
  ]
}

[GrahamCampbell]

This is possibly a breaking change? Maybe best to target 5.6?

[antonioribeiro]

dd() is the last frontier, since there's nothing after it, it cannot break our apps...

[laurencei]

I think it's a great PR.

Technically @GrahamCampbell could be correct though.

If someone was running an API and returning the output of a HTTP call via dd($var) - this would change the output of the API result?

I know no one should be doing that - but I've seen this type of silly stuff in people's questions/answers on StackoverFlow, reddit etc - so it is occurring out there.

The question is, because they are not using it in the intended manner, do we hold off on the PR because of people doing it the "wrong" way... I dont mind either way - just putting it out there.