[5.5] Apply custom pivot model attribute casting on arrays

[themsaid]

Currently attaching/syncing multiple records doesn't trigger the attribute casting on the custom pivot model:

$project->collaborators()->attach([
            [$user->id => ['permissions' => ['foo' => 'bar']]],
            [$user2->id => ['permissions' => ['baz' => 'bar']]],
        ]);

class CustomPivotModel extends Pivot
{
    protected $casts = [
        'permissions' => 'json',
    ];
}

[chelout]

Try this case, it fails:

    public function test_casts_are_respected_on_sync_array()
    {
        $user = CustomPivotCastTestUser::forceCreate([
            'email' => '[email protected]',
        ]);

        $user2 = CustomPivotCastTestUser::forceCreate([
            'email' => '[email protected]',
        ]);

        $project = CustomPivotCastTestProject::forceCreate([
            'name' => 'Test Project',
        ]);

        $project->collaborators()->attach([
            $user->id => ['permissions' => ['foo' => 'bar']],
            $user2->id => ['permissions' => ['baz' => 'bar']],
        ]);
        $project->collaborators()->sync([
            $user->id => ['permissions' => ['foo1' => 'bar1']],
            $user2->id => ['permissions' => ['baz2' => 'bar2']],
        ]);
        $project = $project->fresh();

        $this->assertEquals(['foo' => 'bar'], $project->collaborators[0]->pivot->permissions);
        $this->assertEquals(['baz' => 'bar'], $project->collaborators[1]->pivot->permissions);
    }

[themsaid]

@chelout if course it does, sync re-creates the records, your assertions are invalid.

[chelout]

Sorry, was in a hurry. Test throws error:

Illuminate\Tests\Integration\Database\EloquentCustomPivotCastTest::test_casts_are_respected_on_sync_array
ErrorException: Array to string conversion

Right assertions:

    public function test_casts_are_respected_on_sync_array()
    {
        $user = CustomPivotCastTestUser::forceCreate([
            'email' => '[email protected]',
        ]);

        $user2 = CustomPivotCastTestUser::forceCreate([
            'email' => '[email protected]',
        ]);

        $project = CustomPivotCastTestProject::forceCreate([
            'name' => 'Test Project',
        ]);

        $project->collaborators()->attach([
            $user->id => ['permissions' => ['foo' => 'bar']],
            $user2->id => ['permissions' => ['baz' => 'bar']],
        ]);
        $project->collaborators()->sync([
            $user->id => ['permissions' => ['foo1' => 'bar1']],
            $user2->id => ['permissions' => ['baz2' => 'bar2']],
        ]);
        $project = $project->fresh();

        $this->assertEquals(['foo1' => 'bar1'], $project->collaborators[0]->pivot->permissions);
        $this->assertEquals(['baz2' => 'bar2'], $project->collaborators[1]->pivot->permissions);
    }

[themsaid]

@chelout ah thanks, check now.

[chelout]

Seems fine. Thanks a lot!