[5.5] Let In validation parameters contain commas #21012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevoiusly
was parsed to
in:alpha,beta,gamma,delta
meaning that 4 values would pass this rule instead of the quite explicitly stated 2 possibilities.This PR fixes the above bug by enclosing the listed values by double quotes. This is understood by the function
str_getcsv
which is used later on.Because of introducing extra double quotes, it is necessary to escape existing double quotes (with a double quote, resulting double-double quotes, silly CSV standard...) , this is also implemented here.