Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use installed.json for extra discovery #19455

Merged
merged 3 commits into from
Jun 2, 2017
Merged

Use installed.json for extra discovery #19455

merged 3 commits into from
Jun 2, 2017

Conversation

barryvdh
Copy link
Contributor

@barryvdh barryvdh commented Jun 2, 2017

As suggested @naderman in cb64747#commitcomment-22370108 this uses vendor/composer/installed.json, instead of looping through al package dirs.

Renamed the test to reflect the class, and cleaned up the packages.php file before running the test, to make sure it's fresh.

One note is that the order might change, but I'm not sure if we should assume it always just random?

@naderman
Copy link

naderman commented Jun 2, 2017

Hah I wasn't even looking at the right file oh well ;-)

@barryvdh
Copy link
Contributor Author

barryvdh commented Jun 2, 2017

Taylor rewrote it a few commits later :) a5a0f3e

Hmm, tests are failing because the installed.json is not present. @naderman Should the file always be present, or is that a recent change?

@naderman
Copy link

naderman commented Jun 2, 2017

@barryvdh it's been there since at least 2012: composer/composer@15ab586

@driesvints
Copy link
Member

Sweet!

@taylorotwell taylorotwell merged commit f26e7f8 into laravel:master Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants