Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only return query builder when the result is null for callScope(). #18845

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Only return query builder when the result is null for callScope(). #18845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Database/Eloquent/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ protected function callScope(callable $scope, $parameters = [])
// query as their own isolated nested where statement and avoid issues.
$originalWhereCount = count($query->wheres);

$result = $scope(...array_values($parameters)) ?: $this;
$result = $scope(...array_values($parameters)) ?? $this;

if (count($query->wheres) > $originalWhereCount) {
$this->addNewWheresWithinGroup($query, $originalWhereCount);
Expand Down