-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Added setUnixMode and getUnixMode to Filesystem #16560
Conversation
Could you show an example how this method will be called? This would only work if you first asserted that the filesystem wrapper you use is the locale filesystem, right? Anyone using S3 or Rackspace will get php errors about missing methods? |
@sisve This component is not to be confused with flysytem. |
totally different class, not even same interface: https://github.com/laravel/framework/blob/5.3/src/Illuminate/Filesystem/FilesystemAdapter.php |
Why not just call the method |
@taylorotwell And then with two separate methods (setChmod and getChmod)? Or just one method that accepts two arguments? If only the first is filled, it's a getter, else a setter? |
I would just have one method. |
Am I right @taylorotwell? |
@taylorotwell @marktopper I just combined the two methods into one and renamed it to @marktopper According to the PHP documentation you'll have to pass an octal value, so it would be:
|
Added the possibility to set and get the Unix file permissions in Filesystem.