Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Client Side Tokens #245

Merged

Conversation

HelgeSverre
Copy link
Contributor

I see you previously closed a request related to this, as it was out of scope (However I'm assuming you were referring to the pricing preview feature itself).

Seeing as Paddle has mostly replaced all their documentation to refer to the "client side token" instead of the seller id, I think its wise to add support for- and prefer this method of configuration, as Paddle has stated that this is the preferred way now.

Quote from the changelog.

Existing methods that use seller will continue to work, but future methods may require client-side tokens. We recommend that you replace the seller parameter with token and a client-side token when you're next reviewing your code.

https://developer.paddle.com/changelog/2023/client-side-tokens

Implementation Details

This PR adds the client_side_token configuration key, and uses the PADDLE_CLIENT_SIDE_TOKEN env key.

If no client side token is provided, it use the seller_id as before, however the client_side token will be take precedence over the seller_id if provided.

Breaking changes

None.

This change will not have any effect for existing consumers of the package unless they add the new env or config option to their code.

@driesvints driesvints marked this pull request as draft February 13, 2024 16:06
@driesvints
Copy link
Member

Thanks for the PR! I'll check this with Paddle before merging.

@driesvints driesvints changed the title Add support for Client Side Tokens. Add support for Client Side Tokens Feb 13, 2024
@driesvints driesvints marked this pull request as ready for review February 13, 2024 16:28
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is indeed twtg. Thanks @HelgeSverre.

@taylorotwell taylorotwell merged commit 7887ae5 into laravel:2.x Feb 13, 2024
2 of 7 checks passed
@HelgeSverre HelgeSverre deleted the feature/add-client-side-token-support branch February 16, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants