Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spatie/url 2.0 #154

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Allow spatie/url 2.0 #154

merged 2 commits into from
Feb 18, 2022

Conversation

bashgeek
Copy link
Contributor

Simple change to also allow spatie/url in version 2.0, which raises the minimum to PHP 8.0 (and proper PHP 8.1 support respectively), but does not have any breaking changes, just feature updates.

People on PHP <8.0 can still use the 1.0 version.

@bashgeek
Copy link
Contributor Author

Not sure why the tests are failing, pretty sure it has nothing to do with my PR though :-)

@driesvints
Copy link
Member

@bashgeek Thanks! Tests are failing because your repo doesn't have the correct keys to access the products we use. I should disable these somehow..

@driesvints
Copy link
Member

Hmm that's odd. @bashgeek did you set the env variables from https://github.com/laravel/cashier-paddle/blob/1.x/.github/CONTRIBUTING.md in your GHA? Normally the tests should pass...

You're now getting:

Laravel\Paddle\Exceptions\PaddleException: You don't have permission to access this resource

But that really shouldn't happen unless you attempted to set the env variables and didn't set them correctly.

@bashgeek
Copy link
Contributor Author

@driesvints I didn't setup anything specifically, however, the checks here in the PR are executed against the original repo (yours) and not against the settings in my repo, so the errors originate here. I'd assume you've setup your mentioned ENV vars in the repo, but don't allow them to be run by non-maintainer accounts - which makes sense. I saw that in the PR history, that PRs coming from you (or Taylor) are always succeed the checks, while PR's from others always fail - so I'd guess restricted ENV variables :-)

Can you check if that might be it? Thanks!

@driesvints
Copy link
Member

I found the discrepancy between here and cashier-stripe which uses getenv instead. Pushed an update and got your build to pass 👍

@bashgeek
Copy link
Contributor Author

Even better, great! :)

@taylorotwell taylorotwell merged commit 63e77e6 into laravel:1.x Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants