Update Subscription.php #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow paymentMethod() to be empty string
driesvints
approved these changes
Nov 24, 2021
GrahamCampbell
suggested changes
Nov 24, 2021
| @@ -704,7 +704,7 @@ public function paddleEmail() | |||
| */ | |||
| public function paymentMethod() | |||
| { | |||
| return (string) $this->paddleInfo()['payment_information']['payment_method']; | |||
| return (string) ($this->paddleInfo()['payment_information']['payment_method'] ?? ''); | |||
There was a problem hiding this comment.
Maybe better to return null here, and update the phpdoc. Seems odd to pretend we have a payment method when we don't?
|
I agree it seems weird to return an empty string? @driesvints |
|
Switching to |
|
I don't agree it's breaking, because it never worked, so nobody could be relying on that behaviour. ;) |
|
I think we should be consistent with the other methods. If we want to do this we can change all of them in a future release. |
|
Ok, let's do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow paymentMethod() to be empty string. Subscriptions with "state": "deleted" don't have
payment_informationandpayment_methodrespectively.Solves #147