hasTax() for price
#126
Merged
hasTax() for price
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Update Price.php * Update ProductPriceTest.php * Update Price.php * Update Price.php Co-authored-by: Taylor Otwell <[email protected]>
Merged
|
I noticed this was sent to master so I cherry picked this to master: #149 |
taylorotwell
added a commit
that referenced
this pull request
Jan 6, 2022
* `hasTax()` for price (#126) * Update Price.php * Update ProductPriceTest.php * Update Price.php * Update Price.php Co-authored-by: Taylor Otwell <[email protected]> * Apply fixes from StyleCI Co-authored-by: Lars Klopstra <[email protected]> Co-authored-by: Taylor Otwell <[email protected]> Co-authored-by: StyleCI Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easily check if the price has tax:
In some countries sales tax is not required, this allows for easier conditionals.