Skip to content

Added 8.1 as experimental for tests, dropped 7.1 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexsoft
Copy link
Member

@alexsoft alexsoft commented Oct 5, 2021

  1. Based on this page https://packagist.org/packages/laravel-notification-channels/telegram/php-stats, 7.1 is almost not used, so I think it can be dropped, so I've updated composer.json and tests workflow
  2. Changed coverage workflow to run on 7.4, as scrutinizer ocular script cannot work on 8.0 for now

@alexsoft alexsoft changed the title Experimental 8.1 drop 7.1 Added 8.1 as experimental for tests, dropped 7.1 Oct 5, 2021
@irazasyed irazasyed merged commit c489bb8 into laravel-notification-channels:master Oct 6, 2021
@irazasyed
Copy link
Member

Thank you 👍

@alexsoft
Copy link
Member Author

alexsoft commented Oct 6, 2021

@irazasyed thank you for merging. Do you think this PR could qualify for hacktoberfest? if yes, please add hacktoberfest-accepted label

@irazasyed
Copy link
Member

Done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants