Skip to content

Add GitHub actions #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexsoft
Copy link
Member

@alexsoft alexsoft commented Jan 3, 2021

I guess actions themselves should be enabled in this repository, but I prepared two workflows:

  1. run tests on different versions of php and with different flags (prefer-lowest and prefer-stable)
  2. run tests on php 7.4 with coverage, as there is no need to execute coverage parts on all versions of php

@alexsoft alexsoft marked this pull request as ready for review January 3, 2021 23:01
@alexsoft alexsoft force-pushed the github-actions branch 3 times, most recently from b682b2a to 548e66e Compare January 3, 2021 23:10
@irazasyed
Copy link
Member

Thanks for the PR. This was a much needed one. Appreciate it. 👍

Could you also please add PHP 8 support?

@alexsoft
Copy link
Member Author

alexsoft commented Jan 5, 2021

@irazasyed, sure.
Which version should be used for coverage workflow then? 7.4 or 8.0?

@irazasyed
Copy link
Member

8.0 is good.

@alexsoft
Copy link
Member Author

alexsoft commented Jan 5, 2021

@irazasyed done. I also took the liberty to allow phpunit 9 :)

@irazasyed irazasyed merged commit 66c834e into laravel-notification-channels:master Jan 5, 2021
@irazasyed
Copy link
Member

I noticed that. Good, appreciated :)

Thanks!

@alexsoft
Copy link
Member Author

alexsoft commented Jan 5, 2021

@irazasyed There is still something wrong with scrutinizer, but I am not absolutely sure how to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants