Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vite 3 support for Laravel 9 #115

Merged
merged 12 commits into from
Jul 26, 2022
Merged

add vite 3 support for Laravel 9 #115

merged 12 commits into from
Jul 26, 2022

Conversation

kustomrtr
Copy link

No description provided.

@kustomrtr kustomrtr closed this Jul 26, 2022
@kustomrtr kustomrtr reopened this Jul 26, 2022
@kustomrtr kustomrtr mentioned this pull request Jul 26, 2022
Closed
@danharrin danharrin linked an issue Jul 26, 2022 that may be closed by this pull request
Broken!! after Laravel 9.19 update due to Vite I guess. #114
Closed
@danharrin danharrin added the bug Something isn't working label Jul 26, 2022
@danharrin
Copy link
Member

Can't work out why these tests are failing any clue?

cc/ @ryangjchandler

@kustomrtr
Copy link
Author

@danharrin I think we're missing this: https://github.com/laravel/vite-plugin/blob/main/UPGRADE.md#update-test-helpers
I will take a look at it later after work and run the tests locally, if all is good, I'll update the PR.

@danharrin
Copy link
Member

Thanks for the pointer, that solved it, thanks @kustomrtr!

@danharrin danharrin merged commit 9366368 into laravel-frontend-presets:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken!! after Laravel 9.19 update due to Vite I guess.
3 participants
@kustomrtr @danharrin @kevin-govassist