Merge pull request #19 from laradumps/fix-default-handler

Fix default ide handler
laradumps · Feb 24, 2024 · 3e626de · 3e626de
2 parents e2f6bf0 + e76f7d8
commit 3e626de
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Actions/MakeFileHandler.php b/src/Actions/MakeFileHandler.php
@@ -34,6 +34,10 @@ public static function handle(
 
         $filepath = self::endsWithSeparator(strval($filepath));
 
+        if ($keyHandler === false || empty($keyHandler)) {
+            $keyHandler = 'phpstorm://open?file={filepath}&line={line}';
+        }
+
         $keyHandler = str_replace('{filepath}', $filepath . $filename, $keyHandler);
 
         /** @phpstan-ignore-next-line  */

diff --git a/src/Support/IdeHandle.php b/src/Support/IdeHandle.php
@@ -44,10 +44,6 @@ public function make(): array
         $className = explode('/', $path);
         $className = end($className);
 
-        if ($fileHandle === 'DS_FILE_HANDLER' || $fileHandle === '') {
-            $fileHandle = 'phpstorm://open?file={filepath}&line={line}';
-        }
-
         return [
             'handler'    => $fileHandle,
             'path'       => $path,

diff --git a/tests/Feature/Actions/MakeFileHandlerTest.php b/tests/Feature/Actions/MakeFileHandlerTest.php
@@ -4,7 +4,7 @@
 
 it('returns empty string when there is no .env keys ', function () {
     fixtureEnv('ds_env', ['DS_FILE_HANDLER' => null]);
-    expect(MakeFileHandler::handle(['file' => '/home/index.php', 'line' => 2]))->toBe('');
+    expect(MakeFileHandler::handle(['file' => '/home/index.php', 'line' => 2]))->toBe('phpstorm://open?file=/Users/jamesbond/bomb-disarmer/index.php&line=2');
 });
 
 it('returns empty string when no file is given ', function () {