Default to std::sync::mpsc, introduce crossbeam feature
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panekj
reviewed
Feb 16, 2025
panekj
reviewed
Feb 16, 2025
charlescgs
changed the title
crossbeam feature for ext_event funtions.crossbeam feature
panekj
reviewed
Feb 16, 2025
|
@panekj I think it's good to go now, unless any other improvements can be done. |
|
There has been some discussion on the discord about whether the std channels or crossbeam should be the default. I'm going to go ahead and merge this as is for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions
create_signal_from_channelandupdate_signal_from_channelwere using crossbeam version of the channels, what shouldn't be a default.This PR introduce std channels as a default option and hides crossbeam counterparts behind the 'crossbeam' feature.