[pt] Added AP to rule ID:CRASE_CONFUSION

[marcoagpinto]

An antipattern to fix false positives.

Summary by CodeRabbit

• New Features

  • Enhanced grammar checking capabilities for the Portuguese language module by broadening the scope of recognized patterns.
  • Added two new examples to illustrate the usage of updated grammar rules, providing clearer context for users.

• Bug Fixes

  • Improved exception handling for specific token patterns, refining grammar rule accuracy.

[coderabbitai]

Walkthrough

The pull request modifies the <antipattern> section of the grammar.xml file for the Portuguese language module. It updates the postag attributes of <token> elements to include additional patterns, enhancing the grammar rules' matching criteria. An <exception> element is added to refine exception handling for specific tokens. Additionally, two new <example> entries illustrate the usage of the updated grammar rules, providing context for the changes made.

Changes

File Path	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml	Updated <token> signatures to include additional postag attributes and added an <exception> element. Two new <example> entries were added to demonstrate the updated grammar rules.

Possibly related PRs

• [pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872: This PR adds antipatterns to the grammar.xml file, which is directly related to the changes made in the main PR that also modifies the grammar.xml file for the Portuguese language module.
• [pt] Added APs to rule ID:CONCORDANCIA_SER_GENERO #10919: This PR introduces new antipatterns in the grammar.xml file, similar to the changes in the main PR that enhance grammar checking capabilities by adding new patterns.
• [pt] Added APs to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11034: This PR adds antipatterns to the grammar.xml file, which aligns with the main PR's focus on expanding the grammar rules for Portuguese.

Suggested reviewers

• jaumeortola
• p-goulart

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8b08d9b and 2b790f6.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)

🔇 Additional comments (3)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (3)

13558-13558: LGTM! Exception patterns are well-chosen.

The exception patterns for adverbs, nouns, adjectives, and prepositions will help prevent false positives in common grammatical constructions where 'à/às' usage is correct.

---

13560-13561: LGTM! Examples effectively demonstrate the pattern usage.

The new examples are well-chosen as they demonstrate:

1. Usage with past participle + noun ("aumentadas assimetrias")
2. Usage with past participle + preposition ("praticadas na Grécia")

These examples will be valuable for testing and documentation.

---

13556-13556: LGTM! Token pattern expansion looks correct.

The addition of patterns for past participles (VMP00.+), pronouns (RM), adverbs (RG), and prepositions (SP000) will help reduce false positives by recognizing more valid grammatical constructions.

Let's verify if these patterns match real-world usage:

✅ Verification successful

Let me gather more context about the CRASE_CONFUSION rule and its patterns.

---

Let me check for more antipattern examples in the CRASE_CONFUSION rule to verify the pattern consistency.

---

Token pattern expansion is consistent with Portuguese grammar rules

The added patterns (VMP00.+|RM|RG|SP000) in line 13556 are verified to be:

• Consistent with existing patterns in the CRASE_CONFUSION rule
• Following similar pattern structure as other antipatterns in the grammar file
• Properly expanding coverage for valid grammatical constructions that shouldn't trigger false positives

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for similar patterns in other Portuguese grammar rules
rg -A 2 "postag='.*VMP00\\.\\+.*RM.*RG.*SP000'" languagetool-language-modules/pt/

Length of output: 618

---

Script:

#!/bin/bash
# Search for CRASE_CONFUSION rule definition and its patterns
rg -B 2 -A 5 "CRASE_CONFUSION" languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

Length of output: 723

---

Script:

#!/bin/bash
# Search for all antipatterns in CRASE_CONFUSION rule
rg -B 1 -A 10 "<antipattern>" languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml | grep -A 10 -B 1 "CRASE_CONFUSION"

Length of output: 1171

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.