Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in comments in langsmith/client.py #1447

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fix some typos in comments in langsmith/client.py #1447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/langsmith/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Client for interacting with the LangSmith API.

Check notice on line 1 in python/langsmith/client.py

View workflow job for this annotation

GitHub Actions / benchmark

Benchmark results 

...........
WARNING: the benchmark result may be unstable
* the standard deviation (84.5 ms) is 12% of the mean (691 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

create_5_000_run_trees: Mean +- std dev: 691 ms +- 85 ms
...........
create_10_000_run_trees: Mean +- std dev: 1.41 sec +- 0.10 sec
...........
create_20_000_run_trees: Mean +- std dev: 2.80 sec +- 0.09 sec
...........
dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 713 us +- 7 us
...........
dumps_class_nested_py_leaf_50x100: Mean +- std dev: 25.3 ms +- 0.2 ms
...........
dumps_class_nested_py_leaf_100x200: Mean +- std dev: 104 ms +- 3 ms
...........
dumps_dataclass_nested_50x100: Mean +- std dev: 25.8 ms +- 0.2 ms
...........
WARNING: the benchmark result may be unstable
* the standard deviation (17.9 ms) is 23% of the mean (77.3 ms)

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

dumps_pydantic_nested_50x100: Mean +- std dev: 77.3 ms +- 17.9 ms
...........
dumps_pydanticv1_nested_50x100: Mean +- std dev: 199 ms +- 3 ms

Check notice on line 1 in python/langsmith/client.py

View workflow job for this annotation

GitHub Actions / benchmark

Comparison against main 

+-----------------------------------------------+----------+------------------------+
| Benchmark                                     | main     | changes                |
+===============================================+==========+========================+
| dumps_pydanticv1_nested_50x100                | 216 ms   | 199 ms: 1.09x faster   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_100x200            | 103 ms   | 104 ms: 1.01x slower   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_branch_and_leaf_200x400 | 707 us   | 713 us: 1.01x slower   |
+-----------------------------------------------+----------+------------------------+
| dumps_class_nested_py_leaf_50x100             | 24.8 ms  | 25.3 ms: 1.02x slower  |
+-----------------------------------------------+----------+------------------------+
| dumps_dataclass_nested_50x100                 | 25.2 ms  | 25.8 ms: 1.02x slower  |
+-----------------------------------------------+----------+------------------------+
| create_5_000_run_trees                        | 667 ms   | 691 ms: 1.04x slower   |
+-----------------------------------------------+----------+------------------------+
| create_20_000_run_trees                       | 2.62 sec | 2.80 sec: 1.07x slower |
+-----------------------------------------------+----------+------------------------+
| create_10_000_run_trees                       | 1.31 sec | 1.41 sec: 1.08x slower |
+-----------------------------------------------+----------+------------------------+
| dumps_pydantic_nested_50x100                  | 66.0 ms  | 77.3 ms: 1.17x slower  |
+-----------------------------------------------+----------+------------------------+
| Geometric mean                                | (ref)    | 1.03x slower           |
+-----------------------------------------------+----------+------------------------+

Use the client to customize API keys / workspace ocnnections, SSl certs,
Use the client to customize API keys / workspace connections, SSL certs,
etc. for tracing.

Also used to create, read, update, and delete LangSmith resources
Expand Down
Loading