Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow declaring examples without run function #841

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Conversation

nfcampos
Copy link
Collaborator

This makes examples look clearer and more natural in docs. For now not converting existing examples to simpler format, but that can be done now

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 17, 2023 9:52am

@nfcampos nfcampos merged commit 5720507 into main Apr 17, 2023
@nfcampos nfcampos deleted the nc/examples-top-level branch April 17, 2023 09:59
choonkeat added a commit to choonkeat/langchainjs that referenced this pull request Apr 17, 2023
nfcampos pushed a commit that referenced this pull request Apr 17, 2023
…d guide (#805)

* Add missing function execution

and fix import

* Fix this example too

* use execution framework setup by #841

* fix format
RohitMidha23 pushed a commit to RohitMidha23/langchainjs that referenced this pull request Apr 18, 2023
* Allow declaring examples without `run` function

* Make cheerio test an int test
RohitMidha23 pushed a commit to RohitMidha23/langchainjs that referenced this pull request Apr 18, 2023
…d guide (langchain-ai#805)

* Add missing function execution

and fix import

* Fix this example too

* use execution framework setup by langchain-ai#841

* fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant