Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(google-gauth): Remove logging of error responses #7361

Merged

Conversation

jarib
Copy link
Contributor

@jarib jarib commented Dec 13, 2024

It should be up to the user if they want to log error responses or not. Prompts logged could contain sensitive information.

It should be up to the user if they want to log
error responses or not. Prompts logged could contain
sensitive information.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Dec 13, 2024 5:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 13, 2024 5:14pm

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Dec 13, 2024
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Dec 14, 2024
@jacoblee93 jacoblee93 changed the title Remove logging of error responses fix(google-gauth): Remove logging of error responses Dec 14, 2024
@jacoblee93 jacoblee93 merged commit 1e85e43 into langchain-ai:main Dec 14, 2024
24 of 25 checks passed
@jarib jarib deleted the google-gauth-remove-error-logging branch December 17, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants