feat(community): Prepare implementation IBM WatsonxAI to langchain community package. #6916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:XXL
|
Hey @jacoblee93. |
jacoblee93
reviewed
Oct 7, 2024
jacoblee93
reviewed
Oct 7, 2024
jacoblee93
reviewed
Oct 7, 2024
jacoblee93
reviewed
Oct 7, 2024
jacoblee93
reviewed
Oct 7, 2024
jacoblee93
reviewed
Oct 7, 2024
Provide solutions for: - LLMs - embeddings - tests
Provide solutions for: - LLMs - embeddings - tests * Fix docs, dependencies and minor changes to code
FilipZmijewski
force-pushed
the
main_ibm-community
branch
from
e261bd2 to
db893ce
Compare
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
jacoblee93
reviewed
Oct 11, 2024
* Applied fixes according to review
Provide solutions for: - chat - add tests for chat
jacoblee93
reviewed
Oct 21, 2024
| }; | ||
| } | ||
|
|
||
| model = "mistralai/mistral-large"; |
There was a problem hiding this comment.
Generally we suggest not using a default (models change frequently), but up to you
jacoblee93
reviewed
Oct 21, 2024
|
|
||
| projectId?: string; | ||
|
|
||
| truncate_input_tokens?: number; |
There was a problem hiding this comment.
nit: prefer not mixing camel and snake case
jacoblee93
reviewed
Oct 21, 2024
|
|
||
| version = "2024-05-31"; | ||
|
|
||
| max_new_tokens = 100; |
There was a problem hiding this comment.
nit: avoid mixing camel and snake case
jacoblee93
approved these changes
Oct 21, 2024
jacoblee93
changed the title
|
Thanks for your patience! Will ship later today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare implementation IBM WatsonxAI to langchain community package.
Provide solutions for:
Thank you for contributing to LangChain.js!
Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
Example: "community: add foobar LLM"
Description: The aim of these changes is to create first Langchain.js by IBM implementation. Solutions applied consist of LLMs and embeddings.
fyi @LukaszCmielowski
Expected tests for both of implemented features were added as well as docs and examples