Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google): Fixed - TypeError: Cannot read properties of undefined (reading 'generationInfo') #6756

Merged
merged 3 commits into from
Sep 16, 2024
Merged

fix(google): Fixed - TypeError: Cannot read properties of undefined (reading 'generationInfo') #6756

merged 3 commits into from
Sep 16, 2024

Conversation

pksharmapokhrel
Copy link
Contributor

Fixes #6371 (issue)

While using ChatVertexAI, when the model throws RECITATION error and the response does not contains parts. Since the condition ret.every((item) => typeof item.message.content === "string") (Line 628) is true for ret = [], so it fails when we try to access "generationInfo" property of the first element of the ret in line generationInfo: ret[ret.length - 1].generationInfo (Line 658)

image

Adding the checking ret.length > 0 alongside the existing condition, this will fix the issue.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 13, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 14, 2024 9:04am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Sep 14, 2024 9:04am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Sep 13, 2024
@jacoblee93
Copy link
Collaborator

Thanks fro the PR!

@afirstenberg could you have a look as well if you have time?

@afirstenberg
Copy link
Contributor

I think this is an ok solution.

I would rather the solution we discussed in #6371 to be done, since I think it is easier and more obvious what is going on.

After line 626 add the lines:

    if (parts.length === 0) {
      return [];
    }

Most important - I think either should be added already and a release cut with it.

@afirstenberg
Copy link
Contributor

LGTM

Suggest merge and release.

@jacoblee93 jacoblee93 changed the title Fixed - TypeError: Cannot read properties of undefined (reading 'generationInfo') fix(google): Fixed - TypeError: Cannot read properties of undefined (reading 'generationInfo') Sep 16, 2024
@jacoblee93 jacoblee93 merged commit 68e53a5 into langchain-ai:main Sep 16, 2024
27 checks passed
@jacoblee93
Copy link
Collaborator

Thank you!

@pksharmapokhrel pksharmapokhrel deleted the bugfix/6371 branch September 18, 2024 10:11
FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Sep 27, 2024
@pksharmapokhrel @FilipZmijewski
fix(google): Fixed - TypeError: Cannot read properties of undefined (…
9439454 
…reading 'generationInfo') (langchain-ai#6756)
FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Sep 27, 2024
@pksharmapokhrel @FilipZmijewski
fix(google): Fixed - TypeError: Cannot read properties of undefined (…
e0f58a8 
…reading 'generationInfo') (langchain-ai#6756)
FilipZmijewski added a commit to FilipZmijewski/langchainjs that referenced this pull request Sep 27, 2024
@FilipZmijewski @jacoblee93
@OlegIvaniv @bracesproul @efriis @nickscamara @pksharmapokhrel @rootCircle @AyushExel @dependabot @allohamora @jjangga0214 @stevologic @CahidArda @baskaryan
Bugfix/yarn lock (#6)
8950ce2 
* Create llm and embeddings implementation, include tests (#1)

* Initiate repo, start creating llm solution: generate and stream created

* Exclude authentication outside of the file

* Allow generating text on deployed models, make changes according authentication exclusion

* Extract types outside of llms, small change

* start working on embeddings. create simple tests

* Add some features, rework llm

* Add embeddings

* Create tests for llms and embeddings

* Small fixes

* Adjust to sdk new package

* Rename variables

* Add README.md file

* Rename variables

---------

Co-authored-by: FIlip Żmijewski <[email protected]>

* Add dependencies

* fix(langchain): Fix local file store traversal issue (langchain-ai#6736)

* fix(ci): Fix cf exports test (langchain-ai#6737)

* fix(ci): Fix cf-workers export test (langchain-ai#6738)

* fix(ci): Fix esbuild tests (langchain-ai#6739)

* fix(ci): Fix ci (langchain-ai#6741)

* chore(langchain): Release 0.2.19

* fix(langchain): Prevent exception when using plan & execute agent with no tools (langchain-ai#6744)

Co-authored-by: Brace Sproul <[email protected]>

* fix(openai): Avoid thrown error on o1 stream calls (langchain-ai#6747)

* chore(openai): Release 0.2.11 (langchain-ai#6748)

* docs: Update link (langchain-ai#6757)

* refactor: Move langchain/core to a peer dep (langchain-ai#6698)

Co-authored-by: Brace Sproul <[email protected]>
Co-authored-by: Erick Friis <[email protected]>

* chore(core): Release 0.3.0 (langchain-ai#6760)

* chore(deps): Update deps for 0.3.0 (langchain-ai#6761)

* chore(textsplitters): Release 0.1.0 (langchain-ai#6762)

* chore(cloudflare): Bump dep (langchain-ai#6763)

* chore(openai): Release 0.3.0 (langchain-ai#6764)

* chore(anthropic): Release 0.3.0 (langchain-ai#6765)

* chore(mistralai): Release 0.1.0 (langchain-ai#6766)

* chore(langchain): Release 0.3.0

* chore(build): Update lock (langchain-ai#6770)

* chore(cohere): Release 0.3.0 (langchain-ai#6771)

* chore(weaviate): Release 0.1.0 (langchain-ai#6773)

* chore(aws): Release 0.1.0 (langchain-ai#6775)

* chore(azure-cosmosdb): Release 0.2.0 (langchain-ai#6776)

* chore(azure-dynamic-sessions): Release 0.2.0 (langchain-ai#6777)

* chore(release): Release Baidu, Exa, MixedBread, Nomic (langchain-ai#6778)

* fix(ci): Fix CI issue where local monorepo node_modules were copied into export tests (langchain-ai#6774)

* chore(community): Release 0.3.0 (langchain-ai#6779)

* chore(cloudflare): Release 0.1.0 (langchain-ai#6780)

* chore(groq): Release 0.1.1 (langchain-ai#6781)

* chore(mongodb): Release 0.1.0 (langchain-ai#6782)

* chore(ollama): Release 0.1.0 (langchain-ai#6783)

* chore(pinecone): Release 0.1.0 (langchain-ai#6784)

* chore(qdrant): Release 0.1.0 (langchain-ai#6785)

* chore(redis): Release 0.1.0 (langchain-ai#6786)

* chore(google): Release 0.1.0 (langchain-ai#6787)

* chore(google-genai): Release 0.1.0 (langchain-ai#6788)

* fix(core, langchain): Update langsmith dep to rc (langchain-ai#6797)

* chore(core): Release 0.3.1 (langchain-ai#6800)

* Release 0.3.1

* fix(langchain): Remove circular peer dep in langchain on @langchain/community (langchain-ai#6803)

* chore(langchain): Release 0.3.2 (langchain-ai#6805)

* docs: new algolia index (langchain-ai#6810)

* docs: Adds 0.3 versioning docs (langchain-ai#6793)

* docs: NotFound page suggested links (langchain-ai#6809)

Co-authored-by: jacoblee93 <[email protected]>

* docs: Fix Firecrawl v0 version in the docs (langchain-ai#6768)

* docs: Fix concepts docs hash param (langchain-ai#6816)

* fix(google): Fixed - TypeError: Cannot read properties of undefined (reading 'generationInfo') (langchain-ai#6756)

* fix(ci): Conditionally deplpy api refs to prod (langchain-ai#6819)

* fix(ci): Add vercel ignore file (langchain-ai#6820)

* feat(google-common): Export ChatConnection class (langchain-ai#6823)

* chore(google-common): Release 0.1.1 (langchain-ai#6824)

* fix(core,langchain,community): Update LangSmith deps, lighten export tests (langchain-ai#6825)

* deps: update @anthropic-ai/sdk to 0.27.3 from 0.25.2 (langchain-ai#6796)

Co-authored-by: jacoblee93 <[email protected]>

* chore(anthropic): Release 0.3.1 (langchain-ai#6826)

* docs: Adds warnings to cypher chain about credentials (langchain-ai#6827)

* feat(community): Remove required param from LanceDB integration (langchain-ai#6706)

Co-authored-by: jacoblee93 <[email protected]>

* fix(ci): Fix lint (langchain-ai#6828)

* chore(community): Release 0.3.1 (langchain-ai#6831)

* fix(ci): Update API ref deployment action & vercelignore (langchain-ai#6835)

* fix(core): Fix nested stream events behavior (langchain-ai#6836)

* chore(core): Release 0.3.2 (langchain-ai#6839)

* fix(ci): Add script for aliasing domains in gh deployments (langchain-ai#6838)

* chore(deps): bump the pip group across 1 directory with 2 updates (langchain-ai#6840)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(groq): Feature/groq response format improvements (langchain-ai#6754)

Co-authored-by: jacoblee93 <[email protected]>

* fix(core): Loosen return type of withConfig, fix tracing for nested tool calls (langchain-ai#6847)

* chore(core): Release 0.3.3 (langchain-ai#6848)

* docs(tutorial): fix typo (langchain-ai#6849)

* fix(mistral): Fix call options type (langchain-ai#6857)

* chore(mistralai): Release 0.1.1 (langchain-ai#6858)

* fix: typo fix in agents doc (langchain-ai#6859)

* feat(community): Update ChromeLLM with latest experimental API (langchain-ai#6861)

* chore(community): Release 0.3.2 (langchain-ai#6862)

* fix(community): bump `@upstash/ratelimit` version (langchain-ai#6832)

Co-authored-by: bracesproul <[email protected]>

* fix(docs): Drop announcement bar (langchain-ai#6863)

* groq[patch]: set api key attr (langchain-ai#6864)

Co-authored-by: jacoblee93 <[email protected]>

* chore(groq): Release 0.1.2 (langchain-ai#6865)

* chore(openai,anthropic): Expose OpenAI and Anthropic payload formatters (langchain-ai#6872)

* chore(openai): Release 0.3.1 (langchain-ai#6874)

* chore(anthropic): Release 0.3.2 (langchain-ai#6875)

* feat(anthropic,openai): Add payload formatting utils to Anthropic and OpenAI (langchain-ai#6876)

* chore(openai): Release 0.3.2 (langchain-ai#6877)

* chore(anthropic): Release 0.3.3 (langchain-ai#6878)

* community[patch]: support AWS_... env vars (langchain-ai#6866)

* chore(community): Release 0.3.3 (langchain-ai#6880)

* Fix yarn.lock file

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: FIlip Żmijewski <[email protected]>
Co-authored-by: Jacob Lee <[email protected]>
Co-authored-by: oleg <[email protected]>
Co-authored-by: Brace Sproul <[email protected]>
Co-authored-by: Erick Friis <[email protected]>
Co-authored-by: Nicolas <[email protected]>
Co-authored-by: Prakash Pokharel <[email protected]>
Co-authored-by: Lab Rat <[email protected]>
Co-authored-by: Ayush Chaurasia <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Herman Hrand <[email protected]>
Co-authored-by: jjangga0214 <[email protected]>
Co-authored-by: Stephen M Abbott <[email protected]>
Co-authored-by: Cahid Arda Öz <[email protected]>
Co-authored-by: Bagatur <[email protected]>
@langchain-ai langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-common [bug]: Gemini response with no parts triggers error
3 participants
@pksharmapokhrel @jacoblee93 @afirstenberg