Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anthropic, mistral: return model_name in response metadata #30048

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Feb 28, 2025

Took a "census" of models supported by init_chat_model-- of those that return model names in response metadata, these were the only two that had it keyed under "model" instead of "model_name".

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 28, 2025
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 28, 2025
@lars20070
Copy link

Very nice. Thanks for the quick fix.

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55pm

@ccurme ccurme enabled auto-merge (squash) February 28, 2025 18:54
@ccurme ccurme merged commit f8ed500 into master Feb 28, 2025
40 checks passed
@ccurme ccurme deleted the cc/response_metadata_model_name branch February 28, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants