Implementing the MMR algorithm for OLAP vector storage #30033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
added 2 commits
February 28, 2025 10:40
ccurme
approved these changes
Feb 28, 2025
Comment on lines
+332
to
+333
| {self.config.column_map["embedding"]}) as dist, | ||
| {self.config.column_map["embedding"]} as embedding |
There was a problem hiding this comment.
It is not a duplicate, it is the same field and needs to be read and calculated
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
Implementing the MMR algorithm for OLAP vector storage:
Support Apache Doris and StarRocks OLAP database.
Example: "vectorstore.as_retriever(search_type="mmr", search_kwargs={"k": 10})"
Implementing the MMR algorithm for OLAP vector storage:
Add tests and docs:
Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.