Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: 06 - Refactoring PDFPlumber #29709

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

community[minor]: 06 - Refactoring PDFPlumber #29709

wants to merge 19 commits into from
+1,701 −200

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Feb 10, 2025

This is one part of a larger Pull Request (PR) that is too large to be submitted all at once. This specific part focuses on updating the PDFPlumber parser.

For more details, see #28970.

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:45am

@pprados pprados mentioned this pull request Feb 10, 2025
Draft
2 tasks
@pprados pprados force-pushed the pprados/06-pdfplumber branch from d812a18 to d3c94a3 Compare February 10, 2025 09:46
@pprados pprados force-pushed the pprados/06-pdfplumber branch from d3c94a3 to d90dde5 Compare February 10, 2025 10:09
@pprados pprados marked this pull request as ready for review February 10, 2025 10:20
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) labels Feb 10, 2025
@pprados
Copy link
Contributor Author

pprados commented Feb 10, 2025

@eyurtsev the next.
I use a special approach to handle capitalized properties. I hope this works for you.
If not, we can “double” the keys to maintain compatibility.

@pprados pprados force-pushed the pprados/06-pdfplumber branch from d90dde5 to 535e222 Compare February 10, 2025 10:33
@pprados
Copy link
Contributor Author

pprados commented Feb 12, 2025

@eyurtsev ping

eyurtsev
eyurtsev approved these changes Feb 16, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 16, 2025
@pprados pprados marked this pull request as draft February 26, 2025 09:01
@pprados pprados marked this pull request as ready for review February 26, 2025 09:27
@dosubot dosubot bot added the 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Feb 26, 2025
@pprados pprados force-pushed the pprados/06-pdfplumber branch from 16086d8 to 9e29acb Compare February 26, 2025 12:56
@pprados pprados force-pushed the pprados/06-pdfplumber branch from 9e29acb to 898e2a5 Compare February 26, 2025 13:02
@pprados pprados force-pushed the pprados/06-pdfplumber branch from 9e2fb9b to 48ef444 Compare February 26, 2025 13:12
@pprados
Copy link
Contributor Author

pprados commented Feb 28, 2025

@eyurtsev all is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

@baskaryan baskaryan Awaiting requested review from baskaryan

@ccurme ccurme Awaiting requested review from ccurme

Assignees

@eyurtsev eyurtsev

Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
PR Reviews
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pprados @eyurtsev