Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: pydantic ^2.5 #26396

Merged
merged 46 commits into from
Sep 13, 2024
Merged

core[patch]: pydantic ^2.5 #26396

merged 46 commits into from
Sep 13, 2024

Conversation

baskaryan
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 4:10pm

@efriis efriis added the partner label Sep 12, 2024
@efriis efriis self-assigned this Sep 12, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. langchain Related to the langchain package labels Sep 12, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 12, 2024
@@ -31,7 +31,7 @@ class DallEAPIWrapper(BaseModel):
async_client: Any = Field(default=None, exclude=True) #: :meta private:
model_name: str = Field(default="dall-e-2", alias="model")
model_kwargs: Dict[str, Any] = Field(default_factory=dict)
openai_api_key: Secret[str] = Field(
openai_api_key: SecretStr = Field(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

.gitignore Outdated
@@ -183,3 +183,5 @@ docs/docs/templates

prof
virtualenv/

$GITHUB_OUTPUT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary?

@@ -54,24 +54,15 @@ jobs:
run: |
make test

- name: Ensure the tests did not create any additional files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just moves it to end so it checks min tests also

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 13, 2024
@baskaryan baskaryan merged commit 070da35 into v0.3rc Sep 13, 2024
100 checks passed
@baskaryan baskaryan deleted the bagatur/pydantic_2_5 branch September 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
langchain Related to the langchain package lgtm PR looks good. Use to confirm that a PR is ready for merging. partner size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants