-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to advanced pool verification #58
Add support to advanced pool verification #58
Conversation
I'll try to ave a look at this PR within the next few days, @gszeliga ! |
I'm having seeing a regression in examples/example_irule_pool_verification.tcl |
Hey @landro! Sorry for the buggy example. It should be fine now! |
1e843f4
to
902ef4c
Compare
@landro It's been a while since I heard from you. Is there anything I can do to unblock this PR? Thanks! |
Guillermo,
Thanks for reminding me. I’ve been very busy for the past few weeks - I’ll try to get a look at it during this week.
… 21. jan. 2019 kl. 23:47 skrev Guillermo Szeliga ***@***.***>:
@landro It's been a while since I heard from you. Is there anything I can do to unblock this PR? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@gszeliga I'm still getting errors:
|
Hey @landro ! Have you checked your I ran the tests again and they look fine this time :(
|
Finally sorted out what was going on. I try to maintain compatibility with Tclsh as much as possible, and therefore had to replace not with ! and fix an issue in the classes match implementation. Thanks for your effort and contribution @gszeliga |
I ran into an issue where
endstate
would not do the job to verify the lastpool
set by aniRule
when wrapped in acatch
expression.This PR attempts to address that by enriching the available building blocks with the following new statements:
given_pools
: where you can declare all available pools to be usedendstate_pool
: an easy way to get back the last pool set by the iRuleThis way, you can have things like:
verify "Final pool is the expected one after a match" "go_to_bar" eq { endstate_pool }
which is super awesome to have handy!
Let me know what you think