Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rudimentary cookie support in http #57

Merged
merged 4 commits into from
Nov 21, 2018
Merged

Rudimentary cookie support in http #57

merged 4 commits into from
Nov 21, 2018

Conversation

kugg
Copy link
Contributor

@kugg kugg commented Nov 13, 2018

Added rudimentary cookie support (based on header) as suggested in #43

@landro
Copy link
Owner

landro commented Nov 15, 2018

I had a quick look at the PR - do you mind adding a small test, @kugg ?

@kugg
Copy link
Contributor Author

kugg commented Nov 19, 2018

I had a quick look at the PR - do you mind adding a small test, @kugg ?

Hi I checked the docs and realized I was far from compliant. I updated the supported functions to follow syntax and added a testcase for each cmd. The structure used today allow for expansion of the other command using the header(Cookie) value as a "array compatible list".

@landro landro merged commit a3f289a into landro:master Nov 21, 2018
@landro
Copy link
Owner

landro commented Nov 21, 2018

Thanks for your contribution, @kugg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants